View Change
1 comment:
File dummyflasher.c:
Patch Set #2, Line 474: free(tmp);
This free was here before. The "emulate" param won't be freed with this change.
Please also move the blank line after the free; it should be attached to the block where tmp was allocated.
To view, visit change 47859. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I37c6dee932e449201d8bbfb03ca6d139da3cb6a2
Gerrit-Change-Number: 47859
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Namyoon Woo <namyoon@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 24 Nov 2020 09:08:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment