Attention is currently required from: Aarya, Nikolai Artemiev, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/flashrom/+/84102?usp=email )
Change subject: Complete and fix progress feature implementation for all operations ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
A comment to fix the tests
I fixed the failing test, `spi_read_chunked_test_success` and also renamed it to `default_spi_read_test_success` because a higher level was needed to invoke progress
Then, it turns out that `setup_progress_from_layout_and_diff` is causing tests in tests/chip.c to timeout. So I decided to split the commit and introduce `setup_progress_from_layout_and_diff` in the next commit (which is not ready yet because tests timeout).
I think `setup_progress_from_layout` is already enough to display progress, it's not optimal but it works. It can be improved in the next commit.