Attention is currently required from: Aarya, Nikolai Artemiev, Sergii Dmytruk.
View Change
1 comment:
Patchset:
Patch Set #1:
A comment to fix the tests
I fixed the failing test, `spi_read_chunked_test_success` and also renamed it to `default_spi_read_test_success` because a higher level was needed to invoke progress
Then, it turns out that `setup_progress_from_layout_and_diff` is causing tests in tests/chip.c to timeout. So I decided to split the commit and introduce `setup_progress_from_layout_and_diff` in the next commit (which is not ready yet because tests timeout).
I think `setup_progress_from_layout` is already enough to display progress, it's not optimal but it works. It can be improved in the next commit.
To view, visit change 84102. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: If1e40fc97f443c4f0c0501cef11cff1f3f84c051
Gerrit-Change-Number: 84102
Gerrit-PatchSet: 3
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 13:59:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>