Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ......................................................................
Patch Set 18:
(4 comments)
File ite_ec.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/eadc7ab1_d6d246b1 PS13, Line 78: struct ite_string {
Added some structure defining those bits. […]
Ack
File ite_ecfw.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/cf2f744a_dd29da37 PS14, Line 105: constant?
yes
Done
https://review.coreboot.org/c/flashrom/+/55715/comment/7a27a807_4d4c9f26 PS14, Line 315: = (blocks_1_2 ? 0x94 : 0x85);
we know the bits / have a struct. let's use it. […]
Replaced with bit field updates
File ite_ecfw.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/d09ec624_2d4ecaf8 PS17, Line 782: if (!ec_write_reg(0xf9, 0x20, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xfa, 0x02, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xfb, 0x00, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xf8, 0xb1, EC_MAX_STATUS_CHECKS)) { : msg_perr("Unable to initialize controller.\n"); : return 1; : } :
drop; done in line #208 already
Done