Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Michael Niewöhner, Sergii Dmytruk.

View Change

4 comments:

• File ite_ec.c:

  • Patch Set #13, Line 78: struct ite_string {

    Added some structure defining those bits. […]

    Ack

• File ite_ecfw.c:

  • Patch Set #14, Line 105: constant?

    yes

    Done

  • Patch Set #14, Line 315: = (blocks_1_2 ? 0x94 : 0x85);

    we know the bits / have a struct. let's use it. […]

    Replaced with bit field updates

• File ite_ecfw.c:

  • Patch Set #17, Line 782:

    	if (!ec_write_reg(0xf9, 0x20, EC_MAX_STATUS_CHECKS) ||
    	    !ec_write_reg(0xfa, 0x02, EC_MAX_STATUS_CHECKS) ||
    	    !ec_write_reg(0xfb, 0x00, EC_MAX_STATUS_CHECKS) ||
    	    !ec_write_reg(0xf8, 0xb1, EC_MAX_STATUS_CHECKS)) {
    		msg_perr("Unable to initialize controller.\n");
    		return 1;
    	}
    
    

    drop; done in line #208 already

    Done

To view, visit change 55715. To unsubscribe, or for help writing mail filters, visit settings.