Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23022 )
Change subject: make args for -r/-w/-v non-positional and optional ......................................................................
Patch Set 8:
(1 comment)
It's moving into the right direction. But I'd still like to have that discussion about CrOS interface compatibility. If we decide to uncon- ditionally keep that (over possibly better interface choices), that's a very influental decision for the project. And shouldn't be made in a review.
Just imagine how fast this change could have been done for flashrom proper if we'd just kept the idea (per region files) and implemented it consistently with good old flashrom quality. I'd estimate a third of the time we already spent so far for gathering old commits, poli- shing, discussing.
Updated the patch, but discussion indeed still needs to happen.