(1 comment)

It's moving into the right direction. But I'd still like to have
that
discussion about CrOS interface compatibility. If we decide to
uncon-
ditionally keep that (over possibly better interface choices),
that's
a very influental decision for the project. And shouldn't be made
in
a review.

Just imagine how fast this change could have been done for flashrom
proper if we'd just kept the idea (per region files) and
implemented
it consistently with good old flashrom quality. I'd estimate a
third
of the time we already spent so far for gathering old commits,
poli-
shing, discussing.

Updated the patch, but discussion indeed still needs to happen.

View Change

To view, visit change 23022. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Gerrit-Change-Number: 23022
Gerrit-PatchSet: 8
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 20 Jan 2018 13:44:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No