Jack Olsen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44308 )
Change subject: flashchips: Add support for Boya Microelectronics BY25Q128AS ......................................................................
Patch Set 4:
(6 comments)
Patch Set 1: Code-Review+1
(7 comments)
Welcome!
Overall, looks good, but with some minor nits about formatting.
Thank you for your review, feedback and insights into the standards of this project. I have applied the changes you suggested (I hope, still figuring out some of Gerrit's finer points :). Anyhow let me know if I can do anything else.
https://review.coreboot.org/c/flashrom/+/44308/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/44308/1//COMMIT_MSG@7 PS1, Line 7: flashrom: Added Support for BoyaMicro BY25Q128AS
A few nits about the commit summary: […]
Done
https://review.coreboot.org/c/flashrom/+/44308/1//COMMIT_MSG@9 PS1, Line 9: Tested on Buspirate
missing period `.` at the end.
Done
https://review.coreboot.org/c/flashrom/+/44308/1/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/44308/1/flashchips.h@211 PS1, Line 211:
These spaces should be a tab (tabs are 8 characters wide in flashrom)
Done
https://review.coreboot.org/c/flashrom/+/44308/1/flashchips.h@212 PS1, Line 212:
Same here, spaces
Done
https://review.coreboot.org/c/flashrom/+/44308/1/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/44308/1/flashchips.c@3445 PS1, Line 3445:
more spaces
Done
https://review.coreboot.org/c/flashrom/+/44308/1/flashchips.c@3446 PS1, Line 3446: Boya
nit: Boya Microelectronics
Done