Patch Set 1: Code-Review+1

(7 comments)

Welcome!

Overall, looks good, but with some minor nits about formatting.

Thank you for your review, feedback and insights into the standards of this project. I have applied the changes you suggested (I hope, still figuring out some of Gerrit's finer points :). Anyhow let me know if I can do anything else.

View Change

6 comments:

• Commit Message:

  • Patch Set #1, Line 7: flashrom: Added Support for BoyaMicro BY25Q128AS

    A few nits about the commit summary: […]

    Done

  • Patch Set #1, Line 9: Tested on Buspirate

    missing period `.` at the end.

    Done

• File flashchips.h:

  • Patch Set #1, Line 211:

    These spaces should be a tab (tabs are 8 characters wide in flashrom)

    Done

  • Patch Set #1, Line 212:

    Same here, spaces

    Done

• File flashchips.c:

  • Patch Set #1, Line 3445:

    more spaces

    Done

  • Patch Set #1, Line 3446: Boya

    nit: Boya Microelectronics

    Done

To view, visit change 44308. To unsubscribe, or for help writing mail filters, visit settings.