Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43608 )
Change subject: buspirate: Add option for setting the aux pin ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/flashrom/+/43608/1/buspirate_spi.c File buspirate_spi.c:
https://review.coreboot.org/c/flashrom/+/43608/1/buspirate_spi.c@284 PS1, Line 284: ; /* Default */ Nit: I'd prefer to explicitly write a value to `aux` here, instead of using the value programmed 50 lines ago. Looks like the pullups code does something like that, though.
https://review.coreboot.org/c/flashrom/+/43608/1/buspirate_spi.c@290 PS1, Line 290: free(tmp); I'd put this inside the if-block, but I see no one else does it here...
https://review.coreboot.org/c/flashrom/+/43608/1/buspirate_spi.c@534 PS1, Line 534: AUX AUX is handled later on now