Patch set 1:Code-Review +1

View Change

3 comments:

• File buspirate_spi.c:

  • Patch Set #1, Line 284: ; /* Default */

    Nit: I'd prefer to explicitly write a value to `aux` here, instead of using the value programmed 50 lines ago. Looks like the pullups code does something like that, though.

  • Patch Set #1, Line 290: free(tmp);

    I'd put this inside the if-block, but I see no one else does it here...

  • Patch Set #1, Line 534: AUX

    AUX is handled later on now

To view, visit change 43608. To unsubscribe, or for help writing mail filters, visit settings.