Nico Huber has posted comments on this change. ( https://review.coreboot.org/21834 )
Change subject: fixup! Convert flashrom to git ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push File util/git-hooks/pre-push:
https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push@34 PS1, Line 34: (([0-9]+.)+([0-9]+))$ Why the outer-most parentheses? Why not start with ^ ? and didn't we agree that stable branches should be named <major>.<minor>.x ? Might have been an idle wish, though.
https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push@51 PS1, Line 51: echo "Neither "Signed-off-by" nor "Acked-by" were found in commit $local_sha in " \ Both Signed-off-by and Acked-by have to be present, don't they? this phrasing doesn't reflect that. The old did, nothing to fix?