Nico Huber posted comments on this change.
Patch set 1:
(2 comments)
Patch Set #1, Line 34: \(\([0-9]\+\.\)\+\([0-9]\+\)\)$
Why the outer-most parentheses? Why not start with ^ ? and didn't
we agree that stable branches should be named <major>.<minor>.x ?
Might have been an idle wish, though.
Patch Set #1, Line 51: echo "Neither \"Signed-off-by\" nor \"Acked-by\" were found in commit $local_sha in " \
Both Signed-off-by and Acked-by have to be present, don't they? this
phrasing doesn't reflect that. The old did, nothing to fix?
To view, visit change 21834. To unsubscribe, visit settings.