Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69268 )
Change subject: tests: Add llvm-cov option and run target for code coverage ......................................................................
Patch Set 14:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69268/comment/bfeace61_dcfba292 PS11, Line 14: TEST=meson test; ninja llvm-cov-tests
I meant to say, test scenario == "build flashrom and run tests with coverage disabled" […]
yes I also ran without coverage (and so does jenkins! V+1)
File meson.build:
https://review.coreboot.org/c/flashrom/+/69268/comment/5bb531b2_b1ceb172 PS14, Line 625: run_target('llvm-cov-cli', command : ['scripts/llvm-cov', classic_cli])
But why this is always run? It should only run when feature is enabled?
This is declaring a run target, its not running anything. It can go inside a feature if, it will be less confusing to a user inspecting the ninja run targets. thanks