Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.

View Change

2 comments:

• Commit Message:

  • Patch Set #11, Line 14: TEST=meson test; ninja llvm-cov-tests

    I meant to say, test scenario == "build flashrom and run tests with coverage disabled" […]

    yes I also ran without coverage (and so does jenkins! V+1)

• File meson.build:

  • Patch Set #14, Line 625: run_target('llvm-cov-cli', command : ['scripts/llvm-cov', classic_cli])

    But why this is always run? It should only run when feature is enabled?

    This is declaring a run target, its not running anything. It can go inside a feature if, it will be less confusing to a user inspecting the ninja run targets. thanks

To view, visit change 69268. To unsubscribe, or for help writing mail filters, visit settings.