Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48840 )
Change subject: realtek_mst_i2c_spi.c: Update PAGE_SIZE and fix write ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/48840/2/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/48840/2/realtek_mst_i2c_spi.c@387 PS2, Line 387: uint8_t block_idx = (start + i) >> 16; : uint8_t page_idx = (start + i) >> 8; : uint8_t byte_idx = start + i;
Generally agree with the first point but I think it's out of scope of this change and rather have th […]
Yeah, I'm fine with doing this on another change. Thanks for acknowledging!