Patch set 2:Code-Review +1

View Change

1 comment:

• File realtek_mst_i2c_spi.c:

  • Patch Set #2, Line 387:

    uint8_t block_idx = (start + i) >> 16;
    		uint8_t page_idx  = (start + i) >>  8;
    		uint8_t byte_idx = start + i;
    

    Generally agree with the first point but I think it's out of scope of this change and rather have th […]

    Yeah, I'm fine with doing this on another change. Thanks for acknowledging!

To view, visit change 48840. To unsubscribe, or for help writing mail filters, visit settings.