Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 )
Change subject: tests: Do not run a test if its driver is not built ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Patchset:
PS3: I think the latest version "patchset 3" does not handle disabled config options properly, I need to have another look.
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/55295/comment/f2e6a6ae_11a8f68d PS1, Line 35: #if CONFIG_DUMMY == 1 : void dummy_init_and_shutdown_test_success(void **state) : { : run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi"); : } : #endif /* CONFIG_DUMMY */
I added `if (CONFIG_xxx)` and it seems to work. […]
Actually, this needs more work, I tried as an experiment to use a config option that is not enabled by default and I get: "error: ‘CONFIG_JLINK_SPI’ undeclared" Because, my understanding Makefile has yes/no for config options but meson has 1/nothing at all. Maybe this will need to return back to #if, but I will have another look.