Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

Patch set 3:Code-Review -1

View Change

2 comments:

• Patchset:

  • Patch Set #3:

    I think the latest version "patchset 3" does not handle disabled config options properly, I need to have another look.

• File tests/init_shutdown.c:

  • Patch Set #1, Line 35:

    #if CONFIG_DUMMY == 1
    void dummy_init_and_shutdown_test_success(void **state)
    {
    	run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi");
    }
    #endif /* CONFIG_DUMMY */
    

    I added `if (CONFIG_xxx)` and it seems to work. […]

    Actually, this needs more work, I tried as an experiment to use a config option that is not enabled by default and I get:
    "error: ‘CONFIG_JLINK_SPI’ undeclared"
    Because, my understanding Makefile has yes/no for config options but meson has 1/nothing at all.
    Maybe this will need to return back to #if, but I will have another look.

To view, visit change 55295. To unsubscribe, or for help writing mail filters, visit settings.