Nico Huber has posted comments on this change. ( https://review.coreboot.org/26261 )
Change subject: Enable writes with active ME ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/26261/2/ichspi.c File ichspi.c:
https://review.coreboot.org/#/c/26261/2/ichspi.c@1607 PS2, Line 1607: ~rwperms
Would this not result in something out of range for the enum?
I guess, I did to much SPARK lately (where you can decide about the bit-width). Thanks for spotting that ;)
https://review.coreboot.org/#/c/26261/2/ichspi.c@1854 PS2, Line 1854: Not all flash regions are freely accessible by flashrom. This is " : "most likely\ndue to an active ME. Please see " : "https://flashrom.org/ME for details.\n")
maybe should be updated to suggest to use layouts now.
Well, it will also show the message below. I have no strong feelings about dropping it entirely, though. Or make it msg_pinfo() (because active ME is the default nowadays).
https://review.coreboot.org/#/c/26261/2/ichspi.c@1867 PS2, Line 1867: ich_spi_rw_restricted
should it not update programmer_may_write ?
Why? the whole idea was to get rid of that.