3 comments:

File ichspi.c:
- Patch Set #2, Line 1607: ~rwperms
  Would this not result in something out of range for the enum?
  I guess, I did to much SPARK lately (where you can decide about
  the bit-width). Thanks for spotting that ;)
- Patch Set #2, Line 1854:
```
Not all flash regions are freely accessible by flashrom. This is "
					  "most likely\ndue to an active ME. Please see "
					  "https://flashrom.org/ME for details.\n")
```
  maybe should be updated to suggest to use layouts now.
  Well, it will also show the message below. I have no strong feelings
  about dropping it entirely, though. Or make it msg_pinfo() (because
  active ME is the default nowadays).
- Patch Set #2, Line 1867: ich_spi_rw_restricted
  should it not update programmer_may_write ?
  Why? the whole idea was to get rid of that.

To view, visit change 26261. To unsubscribe, or for help writing mail filters, visit settings.