Attention is currently required from: Simon Buhrow, Thomas Heijligen, Edward O'Callaghan.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71173 )
Change subject: flashrom.c: Add new erase_by_layout and walk_bylayout implementations ......................................................................
Patch Set 14:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/71173/comment/98be0342_dd628089 PS6, Line 1695: //not enough memory : if (!curcontents || !newcontents) { : ret = 1; : goto _ret; : }
delete?
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/bcf7a74b_a699f252 PS6, Line 1701: (uint8_t*)
don't cast, just use the correct type in the first place in the function definition.
The newcontents buffer may b written while aligning boundaries. So the newcontents needs to be casted as it is `const void *`