Attention is currently required from: Simon Buhrow, Thomas Heijligen, Edward O'Callaghan.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #6, Line 1695:

    	//not enough memory
    	if (!curcontents || !newcontents) {
    		ret = 1;
    		goto _ret;
    	}
    

    delete?

    Done

  • Patch Set #6, Line 1701: (uint8_t*)

    don't cast, just use the correct type in the first place in the function definition.

    The newcontents buffer may b written while aligning boundaries. So the newcontents needs to be casted as it is `const void *`

To view, visit change 71173. To unsubscribe, or for help writing mail filters, visit settings.