Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51706 )
Change subject: dediprog.c: Split up compound conditional statement
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File dediprog.c:
https://review.coreboot.org/c/flashrom/+/51706/comment/41b98bd7_bac247fd
PS1, Line 1276: if (register_spi_master(&spi_master_dediprog))
: return 1;
:
: return dediprog_set_leds(LED_NONE);
I think register_spi_master can be the very last line, means we register something only after all initialisation steps are completed successfully?
Otherwise here register_xxx can succeed, but then set_leds fails and init returns 1, this seems like a contradiction.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/51706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e0179da39279e32a8497466b044b69ec836da8
Gerrit-Change-Number: 51706
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 22 Mar 2021 23:03:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment