Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

Patch set 1:Code-Review +1

View Change

1 comment:

• File dediprog.c:

  • Patch Set #1, Line 1276:

    	if (register_spi_master(&spi_master_dediprog))
    		return 1;
    
    	return dediprog_set_leds(LED_NONE);
    

    I think register_spi_master can be the very last line, means we register something only after all initialisation steps are completed successfully?
    Otherwise here register_xxx can succeed, but then set_leds fails and init returns 1, this seems like a contradiction.

To view, visit change 51706. To unsubscribe, or for help writing mail filters, visit settings.