[flashrom-gerrit] Change in flashrom[master]: realtek_mst_i2c_spi.c: Fix wp gpio toggle

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41125 )

Change subject: realtek_mst_i2c_spi.c: Fix wp gpio toggle
......................................................................

Patch Set 2: Code-Review-2
> Patch Set 2:
>
> (2 comments)

Do you think it is worth even keeping this gpio self-wp assertion function logic?
Maybe the gpio mask should be a param as well if it is to be done properly or maybe it is actually out of scope of flashrom? It's sort of weird case because of the chimera properties of being both a spi master to a slave spi flash and at the same time a MCU.

-2 for now until the direction is fully decided or if we learn more about the chip soon.