Patch Set 2:

(2 comments)

Do you think it is worth even keeping this gpio self-wp assertion function logic?
Maybe the gpio mask should be a param as well if it is to be done properly or maybe it is actually out of scope of flashrom? It's sort of weird case because of the chimera properties of being both a spi master to a slave spi flash and at the same time a MCU.

-2 for now until the direction is fully decided or if we learn more about the chip soon.

Patch set 2:Code-Review -2

View Change

To view, visit change 41125. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I825df3179cdd16f7c7ecf556b5ca29bfe6394346
Gerrit-Change-Number: 41125
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Edward Hill <ecgh@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: Shiyu Sun <sshiyu@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 07 May 2020 03:49:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment