Attention is currently required from: Angel Pons. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52405 )
Change subject: lspcon, realtek_mst: move i2c bus resolution from params to i2c_helper ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52405/comment/ea63dc7a_12c132d1 PS4, Line 9: As with the lspcon_i2c_spi programmer
I'd suggest looking into moving the I2C bus handling code to a common place, i2c_helper_linux. […]
Moving the code to i2c_helper suggests API changes too, so I've done it all in one change on top of the lspcon_i2c_spi change.
File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/52405/comment/1261a6cf_08d9d540 PS4, Line 466: // free bus_str later.
nit: For consistency with existing comments, I'd use C-style
Done
https://review.coreboot.org/c/flashrom/+/52405/comment/e6f5ece5_be3c5978 PS4, Line 536: // bus= and devpath= should be mutually exclusive, but defensively handle both here
This would already be guaranteed by the `get_params` function. […]
Obviated by refactoring.