Attention is currently required from: Angel Pons.

View Change

3 comments:

• Commit Message:

  • Patch Set #4, Line 9: As with the lspcon_i2c_spi programmer

    I'd suggest looking into moving the I2C bus handling code to a common place, i2c_helper_linux. […]

    Moving the code to i2c_helper suggests API changes too, so I've done it all in one change on top of the lspcon_i2c_spi change.

• File realtek_mst_i2c_spi.c:

  • Patch Set #4, Line 466: // free bus_str later.

    nit: For consistency with existing comments, I'd use C-style

    Done

  • Patch Set #4, Line 536: // bus= and devpath= should be mutually exclusive, but defensively handle both here

    This would already be guaranteed by the `get_params` function. […]

    Obviated by refactoring.

To view, visit change 52405. To unsubscribe, or for help writing mail filters, visit settings.