Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )
Change subject: it85spi.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/47655/8/it85spi.c File it85spi.c:
https://review.coreboot.org/c/flashrom/+/47655/8/it85spi.c@240 PS8, Line 240: (struct it85spi_data *)
Yes maybe the assignment makes this cast implicit, but I feel it's better to be explicit here.
https://www.kernel.org/doc/html/v4.10/process/coding-style.html#allocating-m...
Loosely related kernel style is to not cast from void * to specific type:
``` Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language. ```