Patch set 9:Code-Review +2

View Change

1 comment:

• File it85spi.c:

  • Patch Set #8, Line 240: (struct it85spi_data *)

    Yes maybe the assignment makes this cast implicit, but I feel it's better to be explicit here.

    https://www.kernel.org/doc/html/v4.10/process/coding-style.html#allocating-memory

    Loosely related kernel style is to not cast from void * to specific type:

    ```
    Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language.
    ```

To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.