13 Dec
2022
13 Dec
'22
11:48 p.m.
Attention is currently required from: Aarya.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65642 )
Change subject: flashrom.c:Add function to align region to sector boundaries ......................................................................
Patch Set 61:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65642/comment/fc07a04d_9de4964c PS57, Line 1183: layout[i].layout_list[j]
I feel this way the code is more easy to understand -- jth block according to ith erase function.
easier because you wrote it ;)
The intermediates give meaning and types to otherwise very deep and long predicates with much indirection (many pointer dereferences) embedded within.
--
To view, visit https://review.coreboot.org/c/flashrom/+/65642
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I215ea4986aa23360fc65ff761f4e49c6069160ac
Gerrit-Change-Number: 65642
Gerrit-PatchSet: 61
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Comment-Date: Tue, 13 Dec 2022 23:48:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Aarya aarya.chaumal@gmail.com
Gerrit-MessageType: comment