Attention is currently required from: Aarya.
View Change
1 comment:
File flashrom.c:
Patch Set #57, Line 1183: layout[i].layout_list[j]
I feel this way the code is more easy to understand -- jth block according to ith erase function.
easier because you wrote it ;)
The intermediates give meaning and types to otherwise very deep and long predicates with much indirection (many pointer dereferences) embedded within.
To view, visit change 65642. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I215ea4986aa23360fc65ff761f4e49c6069160ac
Gerrit-Change-Number: 65642
Gerrit-PatchSet: 61
Gerrit-Owner: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 23:48:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Aarya <aarya.chaumal@gmail.com>
Gerrit-MessageType: comment