David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38596 )
Change subject: flashcips: Add Spansion S25FL512S ......................................................................
Patch Set 6:
(2 comments)
Let's fix that tiny issue in the commit message and get this merged!
https://review.coreboot.org/c/flashrom/+/38596/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/38596/6//COMMIT_MSG@7 PS6, Line 7: flashcips
missing the 2nd `h`: flashcHips
nice catch
https://review.coreboot.org/c/flashrom/+/38596/6/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/38596/6/flashchips.c@15980 PS6, Line 15980: TEST_OK_PREW
Did you test erase and write as well?
Yep, and I verified them independently as well.