Attention is currently required from: Aarya, Alexander Goncharov, Sam McNally.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email )
Change subject: erasure_layout: Fix double invocation of erasers
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
I still encounter an error. Added comments and logs in the issue tracker.
Thank you! I added one comment to the ticket. If you give me the images I can debug too!
I think these are two different issues. The issue this patch is solving is that every block was erased twice: but the end result was correct, so end user would not notice the issues (and verification works too).
While I think there are two different issues, I would debug yours as well before deciding to submit this one: just in case.
In general, this patch is useful, and also the next one (unit test), I would really want to get it through and have the test running on jenkins.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/77747?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28
Gerrit-Change-Number: 77747
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Sat, 30 Sep 2023 10:59:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment