Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58103 )
Change subject: tests: Add wraps for all variants of stat ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58103/comment/96fa78a4_1ab89f65 PS2, Line 9: all
When considering non-standard symbol names, there is no "all". People […]
Yes you are right, I will do this. Initially I was worried that someone other than me can stumble on this missing wraps, some flashrom developer would have a failing test locally. Don't know how many people are running tests locally though. Keeping the comment unresolved until I gather more info (most likely will do next week).
https://review.coreboot.org/c/flashrom/+/58103/comment/ee05a533_607c08b8 PS2, Line 17: TEST=running tests on two different environments, : with 1) stat64 and 2) __xstat64 invoked
this does sound like minijail sort of thing although the change is harmless. […]
Yes sure, I will do this. Let's keep this comment unresolved.