Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
View Change
2 comments:
Commit Message:
Patch Set #2, Line 9: all
When considering non-standard symbol names, there is no "all". People […]
Yes you are right, I will do this.
Initially I was worried that someone other than me can stumble on this missing wraps, some flashrom developer would have a failing test locally.
Don't know how many people are running tests locally though.
Keeping the comment unresolved until I gather more info (most likely will do next week).
Patch Set #2, Line 17:
TEST=running tests on two different environments,
with 1) stat64 and 2) __xstat64 invoked
this does sound like minijail sort of thing although the change is harmless. […]
Yes sure, I will do this. Let's keep this comment unresolved.
To view, visit change 58103. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4c5c243acde09dc5bb6b2a14042fcd23a49707db
Gerrit-Change-Number: 58103
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 23:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment