[flashrom-gerrit] Change in flashrom[master]: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c

[Simon Glass (Code Review)]

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )

Change subject: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c
......................................................................

Patch Set 10:

(1 comment)

File tests/init_shutdown.c:

https://review.coreboot.org/c/flashrom/+/51487/comment/44701e00_7dd46aae 
PS10, Line 53: MEC1308_SIO_PORT1
> It depends much on what one wants to test. Sharing the numbers with the […]

Yes, that's right...but are we trying to check that the header file has the right constant values? To me a more useful test is that they 'come through' or are dealt with as expected.

If the definitions are considered private, they could go in a header file in the same directory as the driver, perhaps with a _private suffix? Then, just the test can include them