Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File tests/init_shutdown.c:

  • Patch Set #10, Line 53: MEC1308_SIO_PORT1

    It depends much on what one wants to test. Sharing the numbers with the […]

    Yes, that's right...but are we trying to check that the header file has the right constant values? To me a more useful test is that they 'come through' or are dealt with as expected.

    If the definitions are considered private, they could go in a header file in the same directory as the driver, perhaps with a _private suffix? Then, just the test can include them

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.