Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35478 )
Change subject: flashchips.c: Take GD25LQ128C/D from downstream ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35478/1/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/35478/1/flashchips.c@a5919 PS1, Line 5919: printlock
I think you can't remove this as it will create a NULL ptr deref in the dispatch site? Also why remo […]
You're right. In ChromiumOS, both uses of printlock are guarded, but in coreboot, only one of them is guarded.
To your other question: As per the patch description, I was copying the definition from ChromiumOS, which doesn't have a printlock, but is marked TESTED_PREW.