View Change

1 comment:

• File flashchips.c:

  • Patch Set #1, Line 5919: printlock

    I think you can't remove this as it will create a NULL ptr deref in the dispatch site? Also why remo […]

    You're right. In ChromiumOS, both uses of printlock are guarded, but in coreboot, only one of them is guarded.

    To your other question: As per the patch description, I was copying the definition from ChromiumOS, which doesn't have a printlock, but is marked TESTED_PREW.

To view, visit change 35478. To unsubscribe, or for help writing mail filters, visit settings.