Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33666 )
Change subject: flashrom: Make internal functions static
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33666/1/flashrom.c
File flashrom.c:
https://review.coreboot.org/#/c/33666/1/flashrom.c@742
PS1, Line 742: unsigned int len)
Please maintain alignment, or remove line break if it fits in 112 chars.
Done
https://review.coreboot.org/#/c/33666/1/flashrom.c@2239
PS1, Line 2239: int verify_it)
Please maintain alignment. Would prefer the line break after `force,`.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33666
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7b63464bb8b5a25fc004350a188dab6ee5c1a204
Gerrit-Change-Number: 33666
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 21 Jun 2019 20:43:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment