[flashrom-gerrit] Change in flashrom[master]: raiden_debug: Upstream ChromiumOS servo debug board prog

[Damien Zammit (Code Review)]

Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38209 )

Change subject: raiden_debug: Upstream ChromiumOS servo debug board prog
......................................................................

Patch Set 4: Code-Review+1

(1 comment)

Please accept this change.

https://review.coreboot.org/c/flashrom/+/38209/3/usb_device.h 
File usb_device.h:

https://review.coreboot.org/c/flashrom/+/38209/3/usb_device.h@64 
PS3, Line 64: return
> As Nico stated, it is a blocker. Personally, I can't approve a change which introduces it.

Edward is doing flashrom community a great service by upstreaming this work.  Can we please accommodate that the first check-in will not be perfect?  We need to realise that his aim is to remove a whole fork so others can work upstream.  As stated, he can submit further patches to fix this small problem, but please don't block new functionality from entering the tree over some minor detail.