Please accept this change.

Patch set 4:Code-Review +1

View Change

1 comment:

• File usb_device.h:

  • Patch Set #3, Line 64: return

    As Nico stated, it is a blocker. Personally, I can't approve a change which introduces it.

    Edward is doing flashrom community a great service by upstreaming this work. Can we please accommodate that the first check-in will not be perfect? We need to realise that his aim is to remove a whole fork so others can work upstream. As stated, he can submit further patches to fix this small problem, but please don't block new functionality from entering the tree over some minor detail.

To view, visit change 38209. To unsubscribe, or for help writing mail filters, visit settings.