Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59529 )
Change subject: spi25_statusreg: delete spi_read_status_register() ......................................................................
Patch Set 65:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59529/comment/54f1edbc_a78825ba PS63, Line 7: read_status_register
Looking at the code, it is `spi_read_status_register()` function which is deleted :)
Done
https://review.coreboot.org/c/flashrom/+/59529/comment/3a9b3d02_935cf04a PS63, Line 7: spi25_statusreg: delete read_status_register()
Apart from deleting a function, this patch does one more good thing: it propagates error codes (whic […]
Done
https://review.coreboot.org/c/flashrom/+/59529/comment/5eb7c0d1_adf1b075 PS63, Line 8:
Also, it is worth adding one sentence explaining why the function is deleted, something like "The fu […]
Done
https://review.coreboot.org/c/flashrom/+/59529/comment/63a8a3db_36e791fb PS63, Line 11: flashrom -{r,w,E}
Same as for previous patch: maybe a bit more info about chips / or environment where this was tested […]
Done
File spi25.c:
https://review.coreboot.org/c/flashrom/+/59529/comment/d80acd46_7d48025c PS63, Line 307: 500
Maybe I forgot and it was discussed before, but where 500 comes from ? Don't know, but maybe it is w […]
Actually now that I look at it again the number of iterations needs to take into account the poll_delay and how long the operation is allowed to take. If we just do 500 iterations it will definitely be enough, but it may wait for too long.
It should probably be another parameter to the function instead.
I've converted it back to an infinite loop with a FIXME since it's beyond the scope of this change.