Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
5 comments:
Commit Message:
Patch Set #63, Line 7: read_status_register
Looking at the code, it is `spi_read_status_register()` function which is deleted :)
Done
Patch Set #63, Line 7: spi25_statusreg: delete read_status_register()
Apart from deleting a function, this patch does one more good thing: it propagates error codes (whic […]
Done
Also, it is worth adding one sentence explaining why the function is deleted, something like "The fu […]
Done
Patch Set #63, Line 11: flashrom -{r,w,E}
Same as for previous patch: maybe a bit more info about chips / or environment where this was tested […]
Done
File spi25.c:
Maybe I forgot and it was discussed before, but where 500 comes from ? Don't know, but maybe it is w […]
Actually now that I look at it again the number of iterations needs to take into account the poll_delay and how long the operation is allowed to take. If we just do 500 iterations it will definitely be enough, but it may wait for too long.
It should probably be another parameter to the function instead.
I've converted it back to an infinite loop with a FIXME since it's beyond the scope of this change.
To view, visit change 59529. To unsubscribe, or for help writing mail filters, visit settings.