Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83717?usp=email )
Change subject: flashchips: add GD25LF256F ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/83717/comment/35621545_f5365721?usp... : PS1, Line 13: I will have to email you the datasheet.
Yes, that would be great! I will wait for you to send me a datasheet.
I got the datasheet, thank you! You can remove this sentence from commit message.
https://review.coreboot.org/c/flashrom/+/83717/comment/04a502db_2c8d0d2c?usp... : PS1, Line 15: protestion A typo: protestion -> protection
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83717/comment/081658fe_7afdb349?usp... : PS1, Line 6736: GD25LF256F Could you please move this definition to be after GD25LF128E, in the same order as you did for IDs in flashchips.h ? GD25LF128E definition is currently around line 6540
https://review.coreboot.org/c/flashrom/+/83717/comment/374aeb51_840025c2?usp... : PS1, Line 6785: BP4 Lets put the full comment here, as usual:
Called BP4 in datasheet, acts like TB