Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
View Change
4 comments:
Commit Message:
Patch Set #1, Line 13: I will have to email you the datasheet.
Yes, that would be great! I will wait for you to send me a datasheet.
I got the datasheet, thank you! You can remove this sentence from commit message.
Patch Set #1, Line 15: protestion
A typo: protestion -> protection
File flashchips.c:
Patch Set #1, Line 6736: GD25LF256F
Could you please move this definition to be after GD25LF128E, in the same order as you did for IDs in flashchips.h ?
GD25LF128E definition is currently around line 6540
Patch Set #1, Line 6785: BP4
Lets put the full comment here, as usual:
Called BP4 in datasheet, acts like TB
To view, visit change 83717. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I21a71606476e823faa38a7920aa2b10e25d68d26
Gerrit-Change-Number: 83717
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Lim <vlim@gigadevice.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Victor Lim <vlim@gigadevice.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Mon, 05 Aug 2024 09:48:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>