Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42796 )
Change subject: ft2232_spi.c: align with Chrome OS flashrom ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/42796/1/ft2232_spi.c File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/42796/1/ft2232_spi.c@420 PS1, Line 420: DIS_DIV_5;
was this not using the define before because of needing to support older libftdi on other platforms […]
Yeah, it was switched to use DIS_DIV_5 and then switched back in `05151b6dcbba16746aa803069dd6046a82e33599` to support older libftdi. However that was ~6 years ago, and the constant was added to libftdi ~9 years ago.
I think it's ok, but we could conditionally define DIS_DIV_5, like HAVE_FT232H on lines 29-33.