View Change
1 comment:
File ft2232_spi.c:
Patch Set #1, Line 420: DIS_DIV_5;
was this not using the define before because of needing to support older libftdi on other platforms […]
Yeah, it was switched to use DIS_DIV_5 and then switched back in `05151b6dcbba16746aa803069dd6046a82e33599` to support older libftdi. However that was ~6 years ago, and the constant was added to libftdi ~9 years ago.
I think it's ok, but we could conditionally define DIS_DIV_5, like HAVE_FT232H on lines 29-33.
To view, visit change 42796. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I24c20e9b5d7e661d0180699bbd0d1447f6bf816f
Gerrit-Change-Number: 42796
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 26 Jun 2020 06:37:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment